Comments on draft-ietf-radext-filter-04

["Pasi Eronen" <pasi.eronen@nokia.com>]

I've gone through the latest version, and this looks basically
ready. There clearly are other alternative how long rules could have
been handled, but IMHO the chosen approach is good enough (and
spending more time on this issue would be counterproductive).

Some minor editorial suggestions:

1) Section 1.3: "It is recommended that an Error-Cause..." 
Perhaps uppercase "RECOMMENDED" would be appropriate here?

2) Section 2: "the individual filter rules SHOULD be determined by
concatenating the contents of all NAS-Filter-Rule attributes, and then
splitting individual filter rules with the the NUL octet (0x00) as a
delimeter." I don't think "SHOULD" is correct here. How about just
"the individual filter rules _are_ determined..."?

3) Section 4: The text about Diameter-to-RADIUS translation could be
clearer (currently it only describes how the translation works for
>253 octet rules, but not the <253 octet case). Suggested
text (replacing 2nd paragraph):

   "When translating Diameter NAS-Filter-Rule AVPs to RADIUS
   NAS-Filter-Rule attributes, a Diameter/RADIUS gateway adds a NUL
   octet between each individual rule. The Diameter/RADIUS gateway
   then splits rules longer than 253 octets to multiple RADIUS
   NAS-Filter-Rule attributes, and MAY also combined multiple rules
   (or parts of multiple rules) to a single NAS-Filter-Rule attribute.

   When translating RADIUS NAS-Filter-Rule attributes to Diameter
   NAS-Filter-Rule AVPs, the Diameter/RADIUS gateway concatenates all
   the received NAS-Filter-Rule attributes, and determines rule
   boundaries using the NUL octet as a delimiter. Each rule (without
   the NUL octet delimiter) is then encoded as a single Diameter
   NAS-Filter-Rule AVP."

4) Section 7.2 : [Traffic] title is now "RADIUS Attributes for
Filtering and Redirection".

Best regards,
Pasi


--
to unsubscribe send a message to radiusext-request@ops.ietf.org with
the word 'unsubscribe' in a single line as the message text body.
archive: <http://psg.com/lists/radiusext/>