draft-ietf-ccamp-lmp-test-sonet-sdh-01.txt

["Adrian Farrel" <afarrel@movaz.com>]

Hi,

Further to Bert's comments I have some thoughts and typos for you. Sorry if there is any duplication with what Bert has already said.

 

Cheers,

Adrian

 

Section 3.1 Verify Transport Mechanism Field

I think you need to clarify that the values defined here supplement those from other sources (e.g. LMP). You should probably turn the field over to IANA.

 

Section 3.1 J0-16

I think it would really help to show a picture. How about...

                     1                   2                   3

 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1

+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+

| resvd |Msg|I|X|  IF_ID     |X| IF_ID (cont)|X| IF_ID (cont)|X|

+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+

| IF_ID (cont)|X| IF_ID |VerId|X| VerId (cont)|X| VerId (cont)|X|

+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+

| VerId (cont)|X| VerId (cont)|X|V| reserved  |X|

+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+

 

Section 4 bullet 2

I'm not clear what you mean by "A node may request..."

Is this the sender requesting the receiver to report the Test Message it is seeing, or the receiver asking the sender what Test Message it is sending? Or are both allowed?

 

Section 4.1.3 TraceMonitorNack

Could "Invalid Trace Message" errors include the actual Trace Message received in the Nack message?

 

Section 4.1.4 TraceMismatch

ditto

 

Section 4.1.8 TraceReqNack

Hopefully there is a reason for sending this message :-)

What are the error codes? Just "unsupported trace type"?

 

Section 4.1.9 InsertTrace

Can we tell a node to stop sending the specified trace message? Do we care?

 

Section 4.1.10 InsertTraceAck

What is meant by "(i.e. no Trace Mismatch)"?

How could receiving an InsertTrace message generate a trace mismatch?

 

Section 4.1.11 InsertTraceNack

What are the specific errors here?

Error in the value presumably could map to "Invalid Trace Message" (2)

What about Trace Monitoring Not Supported. Presumably this should read "Trace Insertion Not Supported". Do we use "Unsupported Trace Type" (1)?

 

Section 6 IANA

I think you need error codes and Verify Transport Mechanism field here

 

Typos and Nits

==============

Section 1 para 1

"or they may represent a Label Switch Path"

should read "...represent one or more..."

 

Section 1 para 2

delete "being developed as"

 

Section 3 para 2

"This can be initiated..."

Implies there are other ways to initiate the verification process.

 

Section 4.1.1.1 Trace Message field

This definition doesn't apply to the object used in a Trace Report.

 

Lots of section cross-references have spurious whitespace

 

Section 4.1.9 para 1

"that the remote knows the mapping" insert 'node'

 

Section 4.1.9 penultimate para

"used to indicate a trace message occurred." insert 'error'