|
Hi,
Here are my comments. I commented the snapshot of
draft-ietf-netconf-notifications yesterday. Some comments in it are still
valid.
o sec 4
<xs:element
name="stream"
type="streamNameType" minOccurs="0"> Does it imply that a single
<create-subscription> operation can not subscribe multiple
streams?
o sec 5.1 says: an <events>
element at the top level that contains one or more child elements
<eventEntry> ...
But the Figure 10 contains <event> instead
of <eventEntry> element.
o sec 5.1
The label 'Figure 12' is
missing.
o sec 5.1 and sec 5.2
There is <reportingEntity> element in the
Figure 10.
<reportingEntity>
<card>Ethernet0</card>
</reportingEntity>
But in the Figure 12 (its label is
missing) and the Figure 14, <reportingEntity> is changed to
<reportingElement>.
o sec 5.2
The Figure 14 is still wrong:
1. The filtering criteria evaluation is not
consistent with the XPATH _expression_ in the <filter> element.
2. Two '(' are missing.
3. It is hard to read due to different sequence of
conditions.
The XPath filter should be:
<netconf:rpc
message-id="101"
xmlns:netconf="urn:ietf:params:xml:ns:netconf:base:1.0"> <create-subscription xmlns="urn:ietf:params:netconf:capability:notification:1.0"> <filter netconf:type="xpath" xmlns:ex="http://example.com/event/1.0" select="/ex:event[ (ex:eventClass='state' or ex:eventClass='config') and ((ex:eventClass='fault' and ex:severity='critical') or (ex:eventClass='fault' and ex:severity='major') or (ex:eventClass='fault' and ex:severity='minor') or (ex:eventClass='fault' and
ex:reportingEntity/ex:card='Ethernet0'))]"/> </create-subscription> </netconf:rpc> Yan
|