[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: REMINDER: Call for review of RFC 2618bis-2621bis
I did a very quick check on just the first document.
Inline:
> -----Original Message-----
> From: owner-radiusext@ops.ietf.org
> [mailto:owner-radiusext@ops.ietf.org]On Behalf Of Bernard Aboba
> Sent: Thursday, September 15, 2005 07:40
> To: radiusext@ops.ietf.org
> Subject: REMINDER: Call for review of RFC 2618bis-2621bis
>
>
> The revised RADIUS MIB documents are now available on the
> IETF archive:
>
> http://www.ietf.org/internet-drafts/draft-ietf-radext-rfc2618bis-00.txt
SMICng tells me:
C:\bwijnen\smicng\work>smicng radiusAuthClient.inc
W: f(radiusAuthClient.mi2), (29,20) Revision date not in
proper order - most recent comes first
W: f(radiusAuthClient.mi2), (27,20) The first revision
should match the last update for MODULE-IDENTITY
radiusAuthClientMIB
E: f(radiusAuthClient.mi2), (48,24) Sub-Id for item
"radiusAuthClientExtMIB" must be "number" or
"name(number)" format
*** 1 error and 2 warnings in parsing
and smilint tells me:
C:\smi\mibs\work>smilint -m -l 6 -s ./RADIUS-AUTH-CLIENT-MIB
./RADIUS-AUTH-CLIENT-MIB:29: [3] {revision-not-descending}
revision not in reverse chronological order
./RADIUS-AUTH-CLIENT-MIB:48: [2] {bad-identifier-case}
`TBA' should start with a lower case letter
./RADIUS-AUTH-CLIENT-MIB:48: [2] {object-identifier-not-prefix}
Object identifier element `TBA' name only allowed as first
element
So did anyone do MIB SYNTAX checking and review against the
MIB review guidelines in
draft-ietf-ops-mib-review-guidelines-04.txt
Further, when you obsolete/update an earlier MIB module with a new
version, then you have to make sure that all changes are legal
according to the rules in the SMI (RFC2578, sect 10, RFC2579, sect 5
and RFC2580, sect 7). Further, the MIB review guidelines also
talk about MIB module revisions in sect 4.9
So the changes need to be carefully evaluated.
I did a smidiff run that shows the below. I did not yet check,
but maybe it helps you as a WG to check.
C:\smi\mibs\work>smidiff ../ietf/RADIUS-AUTH-CLIENT-MIB ./RADIUS-AUTH-CLIENT-MIB
./RADIUS-AUTH-CLIENT-MIB:12 warning: organization of `RADIUS-AUTH-CLIENT-MIB' changed
./RADIUS-AUTH-CLIENT-MIB:12 warning: description of module identity definition `RADIUS-AUTH-CLIENT-MIB' changed
./RADIUS-AUTH-CLIENT-MIB:29 warning: revision `2005-08-30 00:00' added
../ietf/RADIUS-AUTH-CLIENT-MIB:10 info: previous definition of `RADIUS-AUTH-CLIENT-MIB'
./RADIUS-AUTH-CLIENT-MIB:79 warning: legal status change from `current' to `deprecated' for `radiusAuthServerTable'
../ietf/RADIUS-AUTH-CLIENT-MIB:61 info: previous definition of `radiusAuthServerTable'
./RADIUS-AUTH-CLIENT-MIB:88 warning: legal status change from `current' to `deprecated' for `radiusAuthServerEntry'
../ietf/RADIUS-AUTH-CLIENT-MIB:70 info: previous definition of `radiusAuthServerEntry'
./RADIUS-AUTH-CLIENT-MIB:117 warning: legal status change from `current' to `deprecated' for `radiusAuthServerIndex'
../ietf/RADIUS-AUTH-CLIENT-MIB:99 info: previous definition of `radiusAuthServerIndex'
./RADIUS-AUTH-CLIENT-MIB:127 warning: legal status change from `current' to `deprecated' for `radiusAuthServerAddress'
../ietf/RADIUS-AUTH-CLIENT-MIB:109 info: previous definition of `radiusAuthServerAddress'
./RADIUS-AUTH-CLIENT-MIB:136 warning: legal status change from `current' to `deprecated' for `radiusAuthClientServerPortNumber'
../ietf/RADIUS-AUTH-CLIENT-MIB:118 info: previous definition of `radiusAuthClientServerPortNumber'
./RADIUS-AUTH-CLIENT-MIB:145 warning: legal status change from `current' to `deprecated' for `radiusAuthClientRoundTripTime'
../ietf/RADIUS-AUTH-CLIENT-MIB:127 info: previous definition of `radiusAuthClientRoundTripTime'
./RADIUS-AUTH-CLIENT-MIB:171 warning: legal status change from `current' to `deprecated' for `radiusAuthClientAccessRequests'
../ietf/RADIUS-AUTH-CLIENT-MIB:150 info: previous definition of `radiusAuthClientAccessRequests'
./RADIUS-AUTH-CLIENT-MIB:180 warning: legal status change from `current' to `deprecated' for `radiusAuthClientAccessRetransmissions'
../ietf/RADIUS-AUTH-CLIENT-MIB:159 info: previous definition of `radiusAuthClientAccessRetransmissions'
./RADIUS-AUTH-CLIENT-MIB:189 warning: legal status change from `current' to `deprecated' for `radiusAuthClientAccessAccepts'
../ietf/RADIUS-AUTH-CLIENT-MIB:168 info: previous definition of `radiusAuthClientAccessAccepts'
./RADIUS-AUTH-CLIENT-MIB:199 warning: legal status change from `current' to `deprecated' for `radiusAuthClientAccessRejects'
../ietf/RADIUS-AUTH-CLIENT-MIB:177 info: previous definition of `radiusAuthClientAccessRejects'
./RADIUS-AUTH-CLIENT-MIB:208 warning: legal status change from `current' to `deprecated' for `radiusAuthClientAccessChallenges'
../ietf/RADIUS-AUTH-CLIENT-MIB:186 info: previous definition of `radiusAuthClientAccessChallenges'
./RADIUS-AUTH-CLIENT-MIB:220 warning: legal status change from `current' to `deprecated' for `radiusAuthClientMalformedAccessResponses'
./RADIUS-AUTH-CLIENT-MIB:220 warning: description of object definition `radiusAuthClientMalformedAccessResponses' changed
../ietf/RADIUS-AUTH-CLIENT-MIB:198 info: previous definition of `radiusAuthClientMalformedAccessResponses'
./RADIUS-AUTH-CLIENT-MIB:233 warning: legal status change from `current' to `deprecated' for `radiusAuthClientBadAuthenticators'
./RADIUS-AUTH-CLIENT-MIB:233 warning: description of object definition `radiusAuthClientBadAuthenticators' changed
../ietf/RADIUS-AUTH-CLIENT-MIB:211 info: previous definition of `radiusAuthClientBadAuthenticators'
./RADIUS-AUTH-CLIENT-MIB:243 warning: legal status change from `current' to `deprecated' for `radiusAuthClientPendingRequests'
../ietf/RADIUS-AUTH-CLIENT-MIB:221 info: previous definition of `radiusAuthClientPendingRequests'
./RADIUS-AUTH-CLIENT-MIB:257 warning: legal status change from `current' to `deprecated' for `radiusAuthClientTimeouts'
../ietf/RADIUS-AUTH-CLIENT-MIB:234 info: previous definition of `radiusAuthClientTimeouts'
./RADIUS-AUTH-CLIENT-MIB:270 warning: legal status change from `current' to `deprecated' for `radiusAuthClientUnknownTypes'
../ietf/RADIUS-AUTH-CLIENT-MIB:247 info: previous definition of `radiusAuthClientUnknownTypes'
./RADIUS-AUTH-CLIENT-MIB:280 warning: legal status change from `current' to `deprecated' for `radiusAuthClientPacketsDropped'
../ietf/RADIUS-AUTH-CLIENT-MIB:256 info: previous definition of `radiusAuthClientPacketsDropped'
./RADIUS-AUTH-CLIENT-MIB:566 warning: legal status change from `current' to `deprecated' for `radiusAuthClientMIBGroup'
../ietf/RADIUS-AUTH-CLIENT-MIB:292 info: previous definition of `radiusAuthClientMIBGroup'
./RADIUS-AUTH-CLIENT-MIB:543 warning: legal status change from `current' to `deprecated' for `radiusAuthClientMIBCompliance'
../ietf/RADIUS-AUTH-CLIENT-MIB:279 info: previous definition of `radiusAuthClientMIBCompliance'
Bert
--
to unsubscribe send a message to radiusext-request@ops.ietf.org with
the word 'unsubscribe' in a single line as the message text body.
archive: <http://psg.com/lists/radiusext/>