[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: elmo-folder-open-internal-p always returns nil on multi folder



> I doubt elmo-folder-open-internal-p method is really needed.  Only
> elmo-map.el has a real code for this method.  If map folder always
> should not be re-opened before closed, below code is sufficient.
> (But I don't know whether we can assume that.)

I confirmed elmo-map.el and elmo-pop3.el should not be re-opened
before closed.  elmo-shimbun.el seems be able to be re-opend, as far
as I tested.  Others depend on thier content (e.g., elmo-multi.el
depends on their children).  So I changed elmo as below.

* elmo-folder-open-internal-p method is removed.  Because I doubt
  correct elmo-folder-open-internal-p is available for
  elmo-shimbun.el.  Additionally, we may need to recheck whether
  calling elmo-folder-open-internal-p method is required in other
  places where elmo-folder-open-internal method is called.
* Make elmo-folder-open-internal methods of elmo-map.el and
  elmo-pop3.el to be re-callable before closed.
* elmo-move-messages() always opens source folder.
* elmo-folder-open-internal method of elmo-multi.el always opens it's
  children.

There is no problem for me, but my test is limited.

-- 
Kazuhiro Ito

Attachment: elmo.diff
Description: Binary data