Re: Couple of useful (?) patches

[Dave Abrahams <dave@boostpro.com>]

At Tue, 05 Apr 2011 22:20:50 -0400,
Vitaly Mayatskikh wrote:
> 
> Hi!
> 
> This is follow up to recent issues claimed by Dave Abrahams on wl-en
> list. Indeed, I agree with him, here're fixes:
> 
> First issue is weird MIME buttons appear in quoted reply. I see no
> reason to keep text representation of buttons in reply, do you? To
> work that around I propose to turn on visibility of buttons using
> relatively recent mime-view-buttons-visible patch (was it a year ago?
> or two?) just before reply is going to be rendered. Solution is pretty
> dumb: the whole pre-rendered cache is ripping out now, but... It
> works, and who cares about cache? ;)
> 
> Index: wl-summary.el
> ===================================================================
> RCS file: /cvs/root/wanderlust/wl/wl-summary.el,v
> retrieving revision 1.450
> diff -p -u -w -r1.450 wl-summary.el
> --- wl-summary.el	18 Oct 2010 07:43:32 -0000	1.450
> +++ wl-summary.el	6 Apr 2011 02:06:43 -0000
> @@ -4031,6 +4031,9 @@ Return t if message exists."
>  
>  (defun wl-summary-reply-with-citation (&optional arg)
>    (interactive "P")
> +  (let (mime-view-buttons-visible)
> +    (wl-message-buffer-cache-clean-up)
> +    (wl-summary-redisplay))
>    (when (wl-summary-reply arg t)
>      (goto-char (point-max))
>      (wl-draft-yank-original)
>
> Please, test these patches. If you'll not find any problems, I'm about
> to commit them.
> 

Based on that I wrote

(defadvice wl-summary-reply-with-citation 
  (around wl-summary-reply-sans-mime-buttons activate )
    (let (mime-view-buttons-visible)
      (wl-message-buffer-cache-clean-up)
      (wl-summary-redisplay)
      ad-do-it))

But what I found was that even if I had selected a range of text in
the message buffer, the reply cited everything in the message.  So I
think this one needs some work unless my advice works differently from
your patch somehow.


-- 
Dave Abrahams
BoostPro Computing
http://www.boostpro.com