Dirk-Jan C. Binnema wrote:
>Hi David,
>>>>>> On Mon, 02 Aug 2010 07:40:20 +0300, Dirk-Jan C Binnema wrote:
>>>>>> On Sun, 1 Aug 2010 13:15:00 +0200, David Maus ("DM") wrote:
> DM> I've just checked in a fix to cvs trunk that might fix the problem:
> DM> Expiring from folder mode failed because the source folder was not
> DM> opened but `elmo-folder-move-messages' assumed that this is the case.
> > That sounds fantastic! Will this be available in the git-repo as well? Anyhow,
> > many thanks for this!!
>Ok, have found it now -- the changed version is in the 'origin' branch on
>github. I played a bit with this version, but the problem seems as before; and
>annoyingly, it seems a new problem has been introduced, namely that it seems
>that quite often the message headers in the summary no longer correspond to
>the right message. I.e., when I select in the message in the summary I get a
>preview of a /different/ message. Only removing my elmo-cache seems to resolve
>the issue. I've gone back to master now, which seems to work better - as long
>as I don't use the expire functionality.
Yes, sorry. I didn't check carefully enough for the situation where
messages are moved when the source folder of the move operation is
already opened (i.e. while in Summary). For maildir folders this
caused the initial location database (contains relationship of
message-number and message-file) to be reloaded from disk every time
messages where moved.
I've just checked in a patch that opens the source folder only if it
is not open yet. This fixes the bug I am experiencing with refiling
from Folder and restores correct behavior when refiling in Summary.
>Note, I use scoring / expunging in my folders, could there be some bad
>interaction with your patch?
This patch and the last one does only affect moving messages -- Dunno
about scoring, but expunging was affected.
HTH,
-- David
--
OpenPGP... 0x99ADB83B5A4478E6
Jabber.... dmjena@jabber.org
Email..... dmaus@ictsoc.de
Attachment:
pgpQDlcrIqIQP.pgp
Description: PGP signature