[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Duplicate In-Reply-To entries in reply buffer



> This problem is related with some bugs and risky codes.
> Actual bugs are;
> 
> 1-1. elmo-msgdb-get-message-id-from-buffer assumes buffer is narrowed
> to a message header, but actually it is called from unnarrowed buffer
> in some places.
> 
> 1-2. We have multiple extracting methods for Message-ID and they can't
> extract from some valid header.
> 
> Risky codes are;
> 
> 2-1. elmo-field-body is an alias for std11-fetch-field.  FLIM has
> std11-field-body function which does not assume buffer is narrowed.
> The name of elmo-field-body is confusing.
> 
> 2-2. The name of elmo-msgdb-get-message-id-from-buffer is confusing.
> It makes us to imagine this function extracts Message-ID from whole
> buffer, not narrowed region.

I wrote the patch to fix 1-1, 2-1 and 2-2.  The patch also contains
fix for some functions which would confuse us.  In the patch, I use
std11-fetch-field directly because it is introduced before FLIM 1.13
and I think we don't need to take care of it's availability.

-- 
Kazuhiro Ito

Attachment: wl.diff
Description: Binary data