At Fri, 03 Aug 2012 20:33:27 +0900, Kazuhiro Ito wrote: > > > Actual bugs are; > > > > 1-1. elmo-msgdb-get-message-id-from-buffer assumes buffer is narrowed > > to a message header, but actually it is called from unnarrowed buffer > > in some places. > > > > 1-2. We have multiple extracting methods for Message-ID and they can't > > extract from some valid header. > (snip) > > Fix (my opinion); > (snip) > > 1-2. David's refactoring is efficient. As far as I tested, no major > > performance problem was observed except using lexical analyzer. So, > > if I can customize to disable lexical analyzer in this part, the most > > strict method (such as the combination of lexical analyzer and strict > > regexp in [wl-en: 05189]) would be permissive. > > I wrote the patch to fix 1-2. It is basically based on David's > refactoring. There are two steps for extracting Message-ID. At > first, more strict regexp matching is tested. Some valid headers, > e.g. with comment, whould slip out of this test. But second step > which uses lexical analyzer could pick them up. Because almost > headers would be extracted in first step, I think there are little > performance problem and no custamization for disabling lexical > analyzer is needed. Thanks! I already applied the previous patch to WL main repository and check this one on the weekend (likely tomorrow). Best, -- David -- OpenPGP... 0x99ADB83B5A4478E6 Jabber.... dmjena@jabber.org Email..... dmaus@ictsoc.de
Attachment:
pgpWam9E27Voq.pgp
Description: OpenPGP Digital Signature