[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Small commits: EMACS_FLAGS env variable in Makefile, revert lexical binding in tests/



1. Allow environment variable EMACS_FLAGS in Makefile:

<https://github.com/wanderlust/wanderlust/commit/e38366238>

Allows to add paths to SEMI, FLIM, APEL via Emacs' --directory command
line argument; run `make test' w/o need to change WL-CFG for
dependency paths.

,----
| diff --git a/Makefile b/Makefile
| index e81ef19..80b01da 100644
| --- a/Makefile
| +++ b/Makefile
| @@ -22,10 +22,9 @@ PACKAGEDIR = NONE
|  # For XEmacs or Emacs 21: directory where icon files should go.
|  PIXMAPDIR = NONE
|
| -
|  ################# No need to modify following lines ####################
|  BATCHFLAG = -batch
| -FLAGS     = $(BATCHFLAG) -q -no-site-file
| +FLAGS     = $(BATCHFLAG) -q -no-site-file $(EMACS_FLAGS)
|
|  elc:
|  	$(EMACS) $(FLAGS) -l WL-MK -f compile-wl-package \
`----

2. Revert lexical-binding: t in (parts of) test/

<https://github.com/wanderlust/wanderlust/commit/e56f4acdbc86bfe90d04eeecd0e0e6c9eb088b72>

Lexical binding breaks some unit tests that depend on `lunit-assert'
using `eval'.

,----
| diff --git a/tests/test-elmo-date.el b/tests/test-elmo-date.el
| index 04d7814..1808eb0 100644
| --- a/tests/test-elmo-date.el
| +++ b/tests/test-elmo-date.el
| @@ -1,4 +1,3 @@
| -;; -*- lexical-binding: t -*-
|  (require 'lunit)
|  (require 'elmo-date)
|
| 	Modified   tests/test-elmo-imap4.el
| diff --git a/tests/test-elmo-imap4.el b/tests/test-elmo-imap4.el
| index 0df25f9..bbb824e 100644
| --- a/tests/test-elmo-imap4.el
| +++ b/tests/test-elmo-imap4.el
| @@ -1,4 +1,3 @@
| -;; -*- lexical-binding: t -*-
|  (require 'lunit)
|  (require 'elmo-imap4)
|
| 	Modified   tests/test-elmo-localdir.el
| diff --git a/tests/test-elmo-localdir.el b/tests/test-elmo-localdir.el
| index 27a5aa7..b3eb877 100644
| --- a/tests/test-elmo-localdir.el
| +++ b/tests/test-elmo-localdir.el
| @@ -1,4 +1,3 @@
| -;; -*- lexical-binding: t -*-
|  (require 'lunit)
|  (require 'elmo-localdir)
|
| 	Modified   tests/test-elmo-util.el
| diff --git a/tests/test-elmo-util.el b/tests/test-elmo-util.el
| index 6c0c6b8..01e178f 100644
| --- a/tests/test-elmo-util.el
| +++ b/tests/test-elmo-util.el
| @@ -1,4 +1,3 @@
| -;; -*- lexical-binding: t -*-
|  (require 'lunit)
|  (require 'elmo-util)
|
| 	Modified   tests/test-rfc2368.el
| diff --git a/tests/test-rfc2368.el b/tests/test-rfc2368.el
| index 6cf96e6..763ced2 100644
| --- a/tests/test-rfc2368.el
| +++ b/tests/test-rfc2368.el
| @@ -1,4 +1,3 @@
| -;; -*- lexical-binding: t -*-
|  (require 'lunit)
|  (require 'rfc2368)
|
| 	Modified   tests/test-utf7.el
| diff --git a/tests/test-utf7.el b/tests/test-utf7.el
| index 43d3f15..80cb839 100644
| --- a/tests/test-utf7.el
| +++ b/tests/test-utf7.el
| @@ -1,4 +1,3 @@
| -;; -*- lexical-binding: t -*-
|  (require 'lunit)
|
|  ;; Emacs 21
| 	Modified   tests/test-wl-draft.el
| diff --git a/tests/test-wl-draft.el b/tests/test-wl-draft.el
| index fe71d6e..fb48574 100644
| --- a/tests/test-wl-draft.el
| +++ b/tests/test-wl-draft.el
| @@ -1,4 +1,3 @@
| -;; -*- lexical-binding: t -*-
|  (require 'lunit)
|  (require 'wl-draft)
|
| 	Modified   tests/test-wl-util.el
| diff --git a/tests/test-wl-util.el b/tests/test-wl-util.el
| index f833485..1efc1bf 100644
| --- a/tests/test-wl-util.el
| +++ b/tests/test-wl-util.el
| @@ -1,4 +1,3 @@
| -;; -*- lexical-binding: t -*-
|  (require 'lunit)
|  (require 'wl-util)
`----
--
OpenPGP... 0x99ADB83B5A4478E6
Jabber.... dmjena@jabber.org
Email..... dmaus@ictsoc.de

Attachment: pgpxdfmG0P7t2.pgp
Description: OpenPGP Digital Signature